Arsenal - Improve base backpack checking#10479
Draft
LinkIsGrim wants to merge 1 commit intomasterfrom
Draft
Conversation
LinkIsGrim
added
kind/enhancement
Contributor
Author
|
@Joe-Banks can you test https://github.com/acemod/ACE3/actions/runs/11658584858/artifacts/2139298806 and see if it fixes the issue? (unload any other versions of ACE you have, use just that build) |
|
Yo! Tested with CBA, that version of ACE and GM only, unfortunately it doesn't appear to have fixed it - all four backpacks still grey-out any loadout they're saved with. Tested in the ACE arsenal, same method as before. |
Contributor
Author
|
Alright, back to the drawing board |
LinkIsGrim
commented
Nov 5, 2024
| while { | ||
| (isClass _config) && | ||
| {getNumber (_config >> "scope") > 0} && // Some preset backpacks are scope = 1 | ||
| {getText (_config >> "model") == _model} |
Contributor
Author
There was a problem hiding this comment.
Probably just need to move this around
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
If I never touch this again, it'll be too soon. See comments for edge cases we'll still have.
I don't actually have GM to test. Outsourcing this. Doesn't break vanilla though.
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.